chore(aws): Change RDS instance type from list to dict

prowler-cloud / prowler

Prowler is an Open Source Security tool for AWS, Azure, GCP and Kubernetes to do security assessments, audits, incident response, compliance, continuous monitoring, hardening and forensics readiness. Includes CIS, NIST 800, NIST CSF, CISA, FedRAMP, PCI-DSS, GDPR, HIPAA, FFIEC, SOC2, GXP, Well-Architected Security, ENS and more

Apache License 2.0

10.76k stars 1.53k forks source link

Context

For a new check that will be done soon, it's necessary to iterate over two different services. Using a dictionary type for this is more efficient than using a list. As a result of this change, the rest of the RDS instances checks that currently iterate over a list will need to be modified to ensure they continue functioning properly.

Description

Modified all the checks related to iterating over instances and updated the necessary tests accordingly.

Checklist

Are there new checks included in this PR? Yes / No
- If so, do we need to update permissions for the provider? Please review this carefully.
[ ] Review if the code is being covered by tests.
[ ] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.20%. Comparing base (c2552ee) to head (e6ea3c7). Report is 9 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4851 +/- ## ========================================== + Coverage 89.16% 89.20% +0.03% ========================================== Files 933 933 Lines 28567 28567 ========================================== + Hits 25473 25483 +10 + Misses 3094 3084 -10 ```

prowler-cloud / prowler