Wait-RSJob - customizable progress bar

proxb / PoshRSJob

Provides an alternative to PSjobs with greater performance and less overhead to run commands in the background, freeing up the console and allowing throttling on the jobs.

MIT License

541 stars 87 forks source link

Wait-RSJob - customizable progress bar #209

Open jeffchulg opened 4 years ago

jeffchulg commented 4 years ago

Fixes # .

Changes proposed in this pull request: Wait-RsJob:

Switch to boolean for parameter that shows progress bar
Enable dynamic title and message in displayed progress bar

How to test this code:

Run as usual

Has been tested on (remove any that don't apply):

Powershell 5 and Windows 10

MVKozlov commented 4 years ago

Switch to boolean for parameter that shows progress bar

what is the reason for this replacement ?

jeffchulg commented 4 years ago

@MVKozlov I think it's preferable when you have a config file in which you tell "show progress" or not... Otherwise, there is the need to create two different calls, just for that.

MVKozlov commented 4 years ago

Did you know that -Parameter:value syntax acceptable for both switches and booleans ? Seems not ;) Its a common practice to use it for example for -Confirm:$confirm cases and for -ShowProgress too

jeffchulg commented 4 years ago

No, I didn't know. So, Switch or boolean are very similar then

MVKozlov commented 4 years ago

yes, but switch can be used as a boolean and does not require parameter. But boolean can not and require value. It is a breaking change