proxer / ProxerAndroid

The official Android App of Proxer.Me
https://proxer.me
GNU General Public License v3.0
122 stars 20 forks source link

Add permanent mini drawer for tablets #12

Closed wbpascal closed 7 years ago

wbpascal commented 7 years ago

This Pull Request makes the following changes:

The Pull Request adds a permanent mini drawer to the main page if the user is using a tablet. This was done in order to ease navigation throughout the app by giving the user a better sense of where they currently are and allowing for quicker navigation to the most important parts.

Here are some screenshots from the change:

Drawer closed Drawer open

The following code adjustments were necessary:

rubengees commented 7 years ago

This looks and works great! 👍

I will shortly review. I am quite picky about the code style, so please bear with me. ;)

wbpascal commented 7 years ago

Alright, pushed the changes from the review comments. Can you please take a look at it again? :)

rubengees commented 7 years ago

Looks great overall! Just some small things I found.

rubengees commented 7 years ago

Thank you for this contribution. 👍 I will add you to the contributors in the README, when I'm back at this project :)

wbpascal commented 7 years ago

Sure! Thank you as well for merging my PR 😄