Fix builds for macOS - Githubissues

proximax-storage / cpp-xpx-chain-sdk

ProximaX Sirius-Chain C++ SDK

Apache License 2.0

2 stars 1 forks source link

Fix builds for macOS #1

Closed eugene-babichenko closed 5 years ago

eugene-babichenko commented 5 years ago

This pull request introduces:

Successful builds with macOS GCC (Homebrew GCC 7.4.0 & 9.1.0)
Using conan to fetch dependencies instead of just using git
Several modification in CMakeLists.txt for readability.

WIP

macOS clang builds

carlocayos commented 5 years ago

Please create a PR to a develop branch first

eugene-babichenko commented 5 years ago

@carlocayos Done.

eugene-babichenko commented 5 years ago

@carlocayos Please don't merge it right now, I will also check the build on Windows 10 tomorrow.

pananton commented 5 years ago

@eugene-babichenko I'm also stared to fix build on windows (needed to compile project from win pc for myself and found that it does not build actually). There are few errors there, I fix a few and willf ix remaining tommorow.

pananton commented 5 years ago

@eugene-babichenko Btw, I will create issues for work that I plan to do myself in order to not intersect with your work.

eugene-babichenko commented 5 years ago

@pananton13 I rebased this onto your recent changes. Please check if you are able to build it.