proximitybbdo / engine

FuelPHP setup for BBDO
http://fuelphp.com
4 stars 3 forks source link

config cleanup #41

Closed pierot closed 11 years ago

pierot commented 11 years ago

see https://github.com/proximitybbdo/engine/issues/40

rob-bar commented 11 years ago

For me this looks good...can I merge this? After this merge I'll change the minify config settings and add in more db configuration based on env.

<?php
/**
 * Development database settings.
 */

return array(
    'default' => array(
        'type' => 'mysqli',
        'connection' => array(
            'hostname'          => '127.0.0.1',
            'port'              => '3306',
            'database'          => 'DB_name',
            'username'          => 'user',
            'password'          => 'pass',
            'persistent'        => false,
            'compress'          => true
        ),
        'identifier' => '`',
        'table_prefix' => '',
        'charset' => 'utf8',
        'enable_cache' => false,
        'profiling' => true,
    ),
);
<?php
/**
 * Prod database settings.
 */

return array(
    'default' => array(
        'type' => 'mysqli',
        'connection' => array(
            'hostname'          => 'host',
            'port'              => '3306',
            'database'          => 'DB_name',
            'username'          => 'user',
            'password'          => 'pass',
            'persistent'        => false,
            'compress'          => true
        ),
        'identifier' => '`',
        'table_prefix' => '',
        'charset' => 'utf8',
        'enable_cache' => true,
        'profiling' => false,
    ),
);
jeroenbourgois commented 11 years ago

Go!

Sent from somewhere in the universe, in a galaxy far far away

On 05 Feb 2013, at 09:26, Robbie Bardijn notifications@github.com wrote:

For me this looks good...can I merge this? After this merge I'll change the minify config settings and add in more db configuration based on env.

<?php /**

  • Development database settings. */

return array( 'default' => array( 'type' => 'mysqli', 'connection' => array( 'hostname' => '127.0.0.1', 'port' => '3306', 'database' => 'DB_name', 'username' => 'user', 'password' => 'pass', 'persistent' => false, 'compress' => true ), 'identifier' => '`', 'table_prefix' => '', 'charset' => 'utf8', 'enable_cache' => false, 'profiling' => true, ), ); <?php /**

  • Prod database settings. */

return array( 'default' => array( 'type' => 'mysqli', 'connection' => array( 'hostname' => 'host', 'port' => '3306', 'database' => 'DB_name', 'username' => 'user', 'password' => 'pass', 'persistent' => false, 'compress' => true ), 'identifier' => '`', 'table_prefix' => '', 'charset' => 'utf8', 'enable_cache' => true, 'profiling' => false, ), ); — Reply to this email directly or view it on GitHub.