wasmtime: fix params array getting out of scope.

proxy-wasm / proxy-wasm-cpp-host

WebAssembly for Proxies (C++ host implementation)

Apache License 2.0

84 stars 69 forks source link

wasmtime: fix params array getting out of scope. #272

Closed PiotrSikora closed 2 years ago

PiotrSikora commented 2 years ago

Broken in proxy-wasm/proxy-wasm-cpp-host#217.

Signed-off-by: Piotr Sikora piotrsikora@google.com

PiotrSikora commented 2 years ago

Found in https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/270 while changing the log level for host integration.

I've spent some time chasing this bug last week, because it broke tests under TSan, but it didn't manifest itself in a way that was easy to track, since without the trace-level integration logs, the first time an out-of-scope access was inside Wasmtime, which isn't instrumented.