search

proxy-wasm / proxy-wasm-cpp-host

WebAssembly for Proxies (C++ host implementation)
Apache License 2.0
84 stars 69 forks source link

v8: add missing <cstdint> includes. #383

Closed martijneken closed 9 months ago

martijneken commented 9 months ago

Copy changes from envoyproxy/envoy#29425.

This is a temporary build fix until #382 (major v8 upgrade, 10.7 -> 12.0).

PiotrSikora commented 9 months ago

LGTM. Note that we usually concatenate all patches to v8.patch, so that it's easier to propagate the same file to Envoy.

PiotrSikora commented 9 months ago

LGTM. Note that we usually concatenate all patches to v8.patch, so that it's easier to propagate the same file to Envoy.

Ah, nevermind. I see it came from Envoy.

martijneken commented 9 months ago

Looks like I can't merge it, please do the honors. "The base branch restricts merging to authorized users"

PiotrSikora commented 9 months ago

Looks like I can't merge it, please do the honors. "The base branch restricts merging to authorized users"

I don't have admin anymore, so I cannot override the other failing tests (macOS and cargo-raze). cc @mpwarres