chore: bump rules_python and rules_fuzzing

proxy-wasm / proxy-wasm-cpp-host

WebAssembly for Proxies (C++ host implementation)

Apache License 2.0

84 stars 69 forks source link

chore: bump rules_python and rules_fuzzing #404

Closed martijneken closed 3 months ago

martijneken commented 3 months ago

Fixes macOS CI https://github.com/proxy-wasm/proxy-wasm-cpp-host/issues/384

Upgrade rules_python (0.34.0) and rules_fuzzing (0.5.2)

This requires extracting more WORKSPACE phases:

dependencies -- py_repositories() and toolchains
dependencies_python() -- pip_parse module loading
dependencies_import() -- python/fuzzing/other deps

The new structure roughly matches Envoy WORKSPACE:

envoy_dependencies()
envoy_dependencies_extra() -- not needed here
envoy_python_dependencies()
envoy_dependency_imports()

PiotrSikora commented 3 months ago

This requires extracting more WORKSPACE phases:

dependencies -- py_repositories() and toolchains

dependencies_python() -- pip_parse module loading

dependencies_import() -- python/fuzzing/other deps

Do we need all 3 phases? Could it be 2? Note that this leaks into dependent projects (i.e. Envoy).

martijneken commented 3 months ago

Do we need all 3 phases? Could it be 2?

It cannot be 2:

bazel/dependencies_python.bzl: py_repositories is required earlier for pip_parse in rules_fuzzing_init -- this split is new in rules_python 0.26: https://github.com/bazelbuild/rules_python/issues/1560
bazel/dependencies_import.bzl: rules_fuzzing_init is required earlier for @fuzzing_py_deps install_deps

this leaks into dependent projects (i.e. Envoy)

ACK, it's unfortunate. Envoy should be easy since it has matching/more phases. Longer term bzlmod will fix all of this?