search

proxy-wasm / proxy-wasm-cpp-host

WebAssembly for Proxies (C++ host implementation)
Apache License 2.0
84 stars 69 forks source link

compdb add the compdb support to the proxy_wasm_cpp_host #419

Closed wbpcode closed 1 month ago

wbpcode commented 1 month ago

Add the compdb support to the repo. This could be used to simplify the development process.

Note the grailbio/bazel-compilation-database is archived. But it is still be used by envoyproxy/envoy and works pretty well. So, if it is good enough for envoyproxy/envoy, then it should be good enough for proxy_wasm_cpp_host.

And I also investigate other choices like hedronvision/bazel-compile-commands-extractor, but now it could works for our repo.

wbpcode commented 1 month ago

cc @mpwarres

(PS: we cannot assign the PR, is there a team like assignable?)

PiotrSikora commented 1 month ago

(PS: we cannot assign the PR, is there a team like assignable?)

I believe that only maintainers can assign the PR to someone from an assignable team (there is @proxy-wasm/committers-c), but all codeowners are automatically added as reviewers and notified about the PR.

mpwarres commented 1 month ago

@PiotrSikora LMK if you have further comments, otherwise I'll go ahead and merge this. Thanks!