Closed martijneken closed 1 year ago
Updated CI to use recent clang-format and run daily. PTAL.
Looking at what's going on with addlicense.
Looking at what's going on with addlicense.
addlicense wants me to add this to every BUILD file. Is that desired?
+# Copyright 2023 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
Probably due to https://github.com/google/addlicense/pull/127
Removed BUILD files from addlicense check for now.
Sent #151 and #152. Couldn't figure out how to stack PRs.
Sigh, it looks that
clang-format-9
is no longer available in Ubuntu packages. Could you update it to fix the CI?Also, could you add a daily CI run on schedule to catch those regressions when they happen (see: https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/94497deb683e37c0fc54e252b600de1dd4d47406/.github/workflows/test.yml#L31-L32)?