search

proxy-wasm / proxy-wasm-cpp-sdk

WebAssembly for Proxies (C++ SDK)
Apache License 2.0
140 stars 68 forks source link

Update protobuf libraries #159

Open mpwarres opened 1 year ago

mpwarres commented 1 year ago

As pointed out in https://github.com/envoyproxy/envoy/issues/29546, proxy-wasm-cpp-sdk is using v3.9.1 of the protobuf library, which is from 2019. We should update it.

martijneken commented 1 year ago

+1 we should do this. I tried as part of my emsdk update (to fix a zlib issue) and I ran into some issues propagating copts: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/157#discussion_r1297643204

I propose we finish the emsdk update first, then try to bump protobuf.

mpwarres commented 2 months ago

Updating the protobuf library should make the hack mentioned in these instructions obsolete, since protobuf added support for building with Emscripten in protocolbuffers/protobuf@8e869f7.

As part of updating protobuf, the instructions linked above should be removed.