search

proxy-wasm / proxy-wasm-cpp-sdk

WebAssembly for Proxies (C++ SDK)
Apache License 2.0
140 stars 68 forks source link

Consolidate docker build to use bazel. #71

Closed bianpengyuan closed 2 years ago

bianpengyuan commented 3 years ago

Convert docker based build to use bazel internally. Remove all the unnecessary artifacts such as precompiled protobuf library, protobuf files, and boilerplate script. Also update readme to reflect this change.

ref: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/issues/69

Signed-off-by: Pengyuan Bian bianpengyuan@google.com

bianpengyuan commented 3 years ago

One thing to note is that this not only migrates Docker image build to Bazel, but also removes the ability to build Proxy-Wasm plugins using this SDK with anything else than Bazel, which is the opposite of what @fpesce asked us to do.

The original SDK is just a wrapper of emsdk, with several library pulled in. I am not sure what makes it better than Bazel build experience other than maybe Bazel itself needs some time to learn.

bianpengyuan commented 3 years ago

@PiotrSikora Ok, it should not be hard to maintain a minimum SDK container which only pulls in this SDK repo. Let me update the Dockerfile and add a container based non-Bazel option.

PiotrSikora commented 3 years ago

@bianpengyuan any progress or ETA?

bianpengyuan commented 3 years ago

@PiotrSikora Let me see if I can get it done this week.