rename proxy_set_tick_period to reflect resolution

proxy-wasm / spec

WebAssembly for Proxies (ABI specification)

Apache License 2.0

545 stars 27 forks source link

rename proxy_set_tick_period to reflect resolution #39

Closed bonifaido closed 1 year ago

bonifaido commented 1 year ago

this function is named proxy_set_tick_period_milliseconds at other parts of the spec and across implementations

mathetake commented 1 year ago

Hi @bonifaido, please refer to the context https://github.com/proxy-wasm/spec/pull/40 but tldr is that the vNext/README.md has never been correct. We maintainers are gearing toward project overhaul, so let me close this PR for now. Thank you for your understanding!

PiotrSikora commented 1 year ago

tldr is that the vNext/README.md has never been correct.

vNEXT is correct for what it stands (a work-in-progress draft for the next version of the ABI). It was never supposed to document v0.2.x, so saying "it was never correct" is clearly wrong.