proycon / codemetapy

A Python package for generating and working with codemeta
https://codemeta.github.io/
GNU General Public License v3.0
24 stars 5 forks source link

Person ids wrong gitlab #34

Open broeder-j opened 1 year ago

broeder-j commented 1 year ago

codemetapy usually generates the wrong person urls.

like it creates

https://iffgit.fz-juelich.de/fleur/fleur/person/ingo-heimbach

instead of

https://iffgit.fz-juelich.de/ingo-heimbach

for gitlabs usually the name comes right after the main url. For github this is also the case.

Also sometime it fails to parse the person like for https://gitlab.desy.de/benjamin.bastian/mpl_styles it ends up with:

https://gitlab.desy.de/benjamin.bastian/mpl_styles/person/unknown
proycon commented 1 year ago

These generated URIs are freshly minted resources and served by codemeta-server itself, they are not meant to refer to gitlab/github and are not aware of it. I haven't implemented any automatic URI assignment for persons/organizations (there are plans for ORCID though (#30), as you know)

You can of course have URIs refer to gitlab users, but then you'd have to have the IDs assigned prior to harvesting already (like in codemeta.json or codemeta-harvest.json)

broeder-j commented 1 year ago

Ah ok. I was wondering where the motivation for that URI path came from.

proycon commented 1 year ago

codemetapy will only invent uris if you passed the --baseuri parameter by the way, otherwise you do get a temporary URI internally for a while, but it'll be stripped again upon serialisation, effectively yielding blank nodes.