search

proyecto26 / Phaser-Kinetic-Scrolling-Plugin

Kinetic Scrolling plugin for Canvas using Phaser Framework
https://proyecto26.github.io/Phaser-Kinetic-Scrolling-Plugin/
MIT License
131 stars 26 forks source link

Add movement update callback #9

Closed jorbascrumps closed 6 years ago

jdnichollsc commented 7 years ago

Hi Christopher, Let me check your code at weekend! Thanks, Nicholls

jdnichollsc commented 7 years ago

Hi my friend, Can you add an example please? Check the current examples Thank you for your contribution, Nicholls

jorbascrumps commented 7 years ago

Hi @jdnichollsc! I've added an example and updated the README. Sorry for the delay. Please let me know if anything else is required.

jdnichollsc commented 7 years ago

Hi @iamchristopher, sorry for the delay, I'm very busy, let me check your amazing work this weekend! 👍

jorbascrumps commented 7 years ago

Hi @jdnichollsc, have you had a chance to look at this?

jdnichollsc commented 7 years ago

Hi bro! Sorry, I changed the job and I was very busy, let me check your changes and I want to test on Mobile :)

jdnichollsc commented 6 years ago

@iamchristopher Hi bro, can you check my comments and update the version to 1.0.5 please? Also, can you modify the README to add you as collaborator with your info? 👍 Let me know what you think, Nicholls

jorbascrumps commented 6 years ago

Hi @jdnichollsc, which comments are you referring to?

jdnichollsc commented 6 years ago

@iamchristopher check my comments in your pull request bro 👍 https://github.com/jdnichollsc/Phaser-Kinetic-Scrolling-Plugin/pull/9/files/f8dcff462d0a84c1d3aff07efdab15801bc7f81a#diff-041033fc2aaa3c520a376de14f350de5

jorbascrumps commented 6 years ago

@jdnichollsc There are no comments showing up for me.

jorbascrumps commented 6 years ago

@jdnichollsc Thanks for the feedback! It was quite valuable. I've made the requested changes. Let me know if you need anything else before merging let me know!

jdnichollsc commented 6 years ago

@iamchristopher Thanks bro for your excellent contribution and sorry for the delay! 🍻