search

proyecto26 / RestClient

🦄 A Promise based REST and HTTP client for Unity 🎮
https://assetstore.unity.com/packages/slug/102501
MIT License
1.24k stars 173 forks source link

Added asmdef file #204

Closed kbobnis closed 2 years ago

kbobnis commented 2 years ago

asmdef file is needed to link in a unity project that uses asmdef files.

kbobnis commented 2 years ago

As far as I see i need to add this to the upm branch as well, right?

kbobnis commented 2 years ago

Nevermind my last comment, I saw the CI workflow.

jdnichollsc commented 2 years ago

Hey mate, thanks for this awesome contribution! <3

kbobnis commented 2 years ago

Hi @jdnichollsc

now, the asmdef file is being properly found and I can add it to my project.

But there is a problem with the sample project.

When I import the package, it says:

Library\PackageCache\com.proyecto26.restclient@8a6bc7c6ae\Sample\MainScript.cs(48,15): error CS0117: 'RestClient' does not contain a definition for 'CleanDefaultHeaders'

My question is: Why only this definition is not found? Maybe the dll needs to be regenerated?

jdnichollsc commented 2 years ago

I'm not sure because dlls are being removed in the pipeline for Sample project 🤔

kbobnis commented 2 years ago

Let's move conversation to another PR I created: #205