proyecto26 / react-native-inappbrowser

📱InAppBrowser for React Native (Android & iOS) 🤘
https://www.npmjs.com/package/react-native-inappbrowser-reborn
MIT License
1.32k stars 224 forks source link

iOS: Add formSheetPreferredContentSize prop to allow for custom sized formSheet modals #331

Closed ShaneMckenna23 closed 2 years ago

ShaneMckenna23 commented 2 years ago

PR Checklist

What is the current behavior?

Unable to define the size of formSheet modals on iPad

What is the new behavior?

Added new prop to allow for custom sized formSheet modals on iPad.

Implements #330.

Migration steps:

Screenshots

https://user-images.githubusercontent.com/18077159/156228925-e75433d2-4a04-4a45-9f31-1fedcf6421f8.mov

https://user-images.githubusercontent.com/18077159/156228944-e5a6ce5c-0357-4920-9dbf-0d44935fc17b.mov

jdnichollsc commented 2 years ago

Hey mate, this is amazing!

One question, what happen with the modal if the device is rotated with the browser open? 🤔

Thanks for your contribution! <3

jdnichollsc commented 2 years ago

Thanks for your amazing contribution dude! <3