fix androidXVersion to prevent build fails

IgorVanian commented 1 year ago

PR Checklist

[ ] The PR title follows our guidelines: https://github.com/proyecto26/react-native-inappbrowser/blob/main/CONTRIBUTING.md#pull-request-process.
[x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

The investigation is available here: https://github.com/proyecto26/react-native-inappbrowser/issues/398

This exact problem was already addressed multiple times and we still get surprised by failing builds (#298, #386 ). I think it's worth to set a fixed version to prevent this kind of surprise in the future. 🙏

What is the new behavior?

Fixes androidXVersion to 1.5.+ which is the latest before the kotlin 1.8.0 issue...

Fixes/Implements/Closes #398.

felipecamposfabel commented 1 year ago

Hi. Any plans for merging this commit? A new androidX version 1.6 is out and started to cause problems with SDK 33 now. https://developer.android.com/jetpack/androidx/releases/browser.

I patched it on my project and seems to be working just fine on RN 0.71.7.

Thanks!

jenskuhrjorgensen commented 8 months ago

Awesome, @jdnichollsc and @IgorVanian Is there a planned new release with this fix anytime soon?

jdnichollsc commented 8 months ago

@jenskuhrjorgensen I'm waiting for merging this PR in order to publish a new release https://github.com/proyecto26/react-native-inappbrowser/pull/421

proyecto26 / react-native-inappbrowser