prplfoundation / prplMesh

This repository moved to https://gitlab.com/prpl-foundation/prplmesh/prplMesh
Other
65 stars 32 forks source link

PPM-375 Move the gitlab.com repo used by the scripts #1594

Closed ghost closed 4 years ago

ghost commented 4 years ago

We need to move the gitlab repository used by CI from gitlab.com/prpl-foundation/prplMesh to gitlab.com/prpl-foundation/prplmesh/prplMesh.

This PR is for updating the scripts that work with the repository location.

Don't merge until the move is complete on gitlab.com.

It relies on the following changes: https://git.prpl.dev/prplmesh/wfa-certification/easymesh_cert/-/merge_requests/25

rmelotte commented 4 years ago

I think the only reference left in the repo is the badge in the README:

README.md:[![Build Status](https://gitlab.com/prpl-foundation/prplMesh/badges/master/pipeline.svg)](https://gitlab.com/prpl-foundation/prplMesh/pipelines)
rmelotte commented 4 years ago

Unfortunately I can't find a source for it, but most likely the location where Gitlab clones the repo will change as well. Up to now it was /builds/prpl-foundation/prplMesh/, so it's probably going to be /builds/prpl-foundation/prplmesh/prplMesh/.

Ideally we shouldn't be depending on this path anyway, but unfortunately https://jira.prplfoundation.org/browse/PPM-208 is still open so we have no choice but to do more changes.

This path also has to be used by... drum roll... the certification repo, so we will have to update it as well (I can take care of that).

ghost commented 4 years ago

Unfortunately I can't find a source for it, but most likely the location where Gitlab clones the repo will change as well. Up to now it was /builds/prpl-foundation/prplMesh/, so it's probably going to be /builds/prpl-foundation/prplmesh/prplMesh/.

$ git grep prpl-foundation
.gitlab-ci.yml:    GIT_CLONE_PATH: "/builds/prpl-foundation/prplMesh/"
README.md:[![Build Status](https://gitlab.com/prpl-foundation/prplmesh/prplMesh/badges/master/pipeline.svg)](https://gitlab.com/prpl-foundation/prplmesh/prplMesh/pipelines)
ci/certification/generic.yml:    GIT_CLONE_PATH: "/builds/prpl-foundation/prplMesh/"
tools/download_ipk.sh:        GITLAB_BASE_URL="https://gitlab.com/prpl-foundation/prplmesh/prplMesh/-/jobs/artifacts/"
tools/functions.sh:export DOCKER_REGISTRY=registry.gitlab.com/prpl-foundation/prplmesh/prplmesh/

The gitlab docs have this to say:


Git clone path
Introduced in GitLab Runner 11.10.

GIT_CLONE_PATH allows you to control where you clone your sources. This can have implications if you heavily use big repositories with fork workflow.

Fork workflow from GitLab Runner’s perspective is stored as a separate repository with separate worktree. That means that GitLab Runner cannot optimize the usage of worktrees and you might have to instruct GitLab Runner to use that.

In such cases, ideally you want to make the GitLab Runner executor be used only for the given project and not shared across different projects to make this process more efficient.

The GIT_CLONE_PATH has to be within the $CI_BUILDS_DIR. Currently, it is impossible to pick any path from disk.


I don't think we even need `GIT_CLONE_PATH`, we don't seem to use it anywhere? Unless ...

> This path also has to be used by... drum roll... the certification repo, so we will have to update it as well (I can take care of that).

... it's used in the other repos :-)

**EDIT**: But even so, I don't think the repo location necessarily impacts what value we have to use for `GIT_CLONE_PATH`, we can just keep it the same. Which means the other repos should be unaffected
rmelotte commented 4 years ago

It doesn't have to do with the fact that we use another rrepo, it's used implicitly by Gitlab. See for example the docker builds: they are built in /builds/prpl-foundation/prplMesh/ even though we didn't specify that path ourselves anywhere.

As for why we need a changes:

EDIT: I added the changes I describe here in a new commit.

ghost commented 4 years ago

The move was completed. We'll need to merge this PR soon

rmelotte commented 4 years ago

@mergifyio rebase

mergify[bot] commented 4 years ago

Command rebase: success

Branch already up to date

rmelotte commented 4 years ago

The pipeline related to this PR was deleted, I created a new one to check if it works: https://gitlab.com/prpl-foundation/prplmesh/prplMesh/-/pipelines/177175447

rmelotte commented 4 years ago

The pipeline succeeded, so I will merge this one and rebase the other branches.