search

prprprus / PyMySQLPool

PyMySQL-based database connection pool.
MIT License
60 stars 21 forks source link

Close resize pool thread when main thread finishes #7

Closed holahmeds closed 4 years ago

holahmeds commented 5 years ago

If we don't mark the resize pool thread as daemon, it keeps running even after the main thread is finished. This keeps the process from exiting.

codecov-io commented 5 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files           3        3           
  Lines         169      169           
=======================================
  Hits          142      142           
  Misses         27       27
Impacted Files Coverage Δ
pymysqlpool/pool.py 68.6% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa5ec72...84f6c0b. Read the comment docs.

archongum commented 4 years ago

Why not merging this?

prprprus commented 4 years ago

Thanks, merged @holahmeds

mindflayer commented 4 years ago

Could you please release a new version on PyPI containing this change?