search

prrao87 / db-hub-fastapi

Async bulk data ingestion and querying in various document, graph and vector databases via their Python clients
MIT License
33 stars 3 forks source link

Meilisearch with Pydantic v2 #31

Closed sanders41 closed 1 year ago

sanders41 commented 1 year ago

I saw you updated Neo4j to use Pydantic 2, meilisearch-python-async has also been updated with support for Pydantic 2. I have been meaning to try that out and see what difference it makes here, but just haven't gotten to it yet.

prrao87 commented 1 year ago

Awesome! Yes, I in fact had some local commits that I haven't pushed yet to run it for the Meilisearch case next... Other than the initial data validation step, are there other areas where the async Meilisearch client is affected by pydantic v2's release?

I'll push my changes later today and maybe you can take a look to see if there's something more to be gained?

sanders41 commented 1 year ago

The latest update just added support for Pydantic v2, there should be no user facing changes. I'm happy to take a look when you push it if you want.