search

prrrnd / atom-git-projects

List and open your local Git projects in Atom.
MIT License
37 stars 18 forks source link

Support multiple root paths #4

Closed mark-hahn closed 9 years ago

mark-hahn commented 9 years ago

I have three different folders containing projects and this aggregates projects from all three.

prrrnd commented 9 years ago

That's a great idea, thanks @mark-hahn. Tests are failing though, would you mind updating them?

mark-hahn commented 9 years ago

The tests pass with ctrl-alt-P on my pc. I don't understand the travis error ...

The command "curl -s https://raw.githubusercontent.com/atom/ci/master/build-package.sh | sh" exited with 1.

It doesn't seem related to my PR.

prrrnd commented 9 years ago

I believe the command exited because the tests failed.

2 tests, 2 assertions, 1 failure, 0 skipped

Tests failed

I'll try to look at it when I have some time. Thanks for your contribution!

mark-hahn commented 9 years ago

I'm curious. What was the problem? Was it my fault?

On Thu, Feb 19, 2015 at 10:50 AM, Pierre Arnaud notifications@github.com wrote:

Merged #4 https://github.com/prrrnd/atom-git-projects/pull/4.

— Reply to this email directly or view it on GitHub https://github.com/prrrnd/atom-git-projects/pull/4#event-238598695.

prrrnd commented 9 years ago

Somehow rootPath was undefined, causing an error with the split. I quickly fixed it with this commit, but I'm not sure why this happened. I'll have a better look at it when I have some time, hopefully later today. You're welcome to investigate if you have some time :-)

mark-hahn commented 9 years ago

Somehow rootPath was undefined,

You are talking about the tests after my second and final commit, right?

Interesting, I don't know if you noticed but my first commit changed rootPath to rootPaths. Then I realized that would screw up existing user's settings. So I did a second commit that went back to rootPath. Maybe I missed one. I'll check right now. In any case the tests passed on my PC 2/2.

On Thu, Feb 19, 2015 at 11:10 PM, Pierre Arnaud notifications@github.com wrote:

Somehow rootPath was undefined, causing an error with the split. I quickly fixed it with this commit https://github.com/prrrnd/atom-git-projects/commit/f3cd7a1307d17ac68901aaf2a561287a02f792aa, but I'm not sure why this happened. I'll have a better look at it when I have some time, hopefully later today. You're welcome to investigate if you have some time :-)

— Reply to this email directly or view it on GitHub https://github.com/prrrnd/atom-git-projects/pull/4#issuecomment-75198575 .