Closed jccr closed 9 years ago
Wow, that's awesome! :+1: I am going to look at it in details as soon as I have some free time - probably this weekend.
@prrrnd Thanks!
I've pushed a few more commits that might help out with some issues I have encountered so far:
Hey @JCCR, I have looked at what you did in more details, and I have to say, it's pretty impressive. Good job! :+1: I don't have much more to say, it seems pretty neat to me, and that's a really great improvement in general. The only thing I see that could perhaps be slightly improved is how the size of the task pool is defined. What do you think are the possible options / how could we define a decent value? Are you still working on something, or do you want me to merge now?
@prrrnd Whoops, I must have left that in while testing. The reassignment to 3 shouldn't be there. I'll fix it.
Oh and no I'm not working on something, I think it looks good to me as well. Thanks for looking it over :)
Awesome, thanks! I'll merge now :)
It's so much more fun to use now. Awesome, thanks!
Fixes #41
Before:
Notes:
After:
Notes:
It would be nice if this code could be cleaned up further, and a more comprehensive spec added to cover the new caching features. (I got stuck when thinking about how to create the spec)