Closed mark-hahn closed 9 years ago
I'll assume you want me to just add this speedup to my PR.
I believe activationEvents
have been renamed to activationCommands
. The reason it is not implemented is because I thought that git-projects
had to be loaded when opening Atom as it is the first thing I use to open any of my projects. If it improves the performances, and if you're willing to include this in your PR, then it can only be a good thing :+1:
as it is the first thing I use to open any of my projects
It would not harm that usage.
On Tue, Mar 3, 2015 at 1:20 AM, Pierre Arnaud notifications@github.com wrote:
I believe activationEvents have been renamed to activationCommands. The reason it is not implemented is because I thought that git-projects had to be loaded when opening Atom as it is the first thing I use to open any of my projects. If it improves the performances, and if you're willing to include this in your PR, then it can only be a good thing [image: :+1:]
— Reply to this email directly or view it on GitHub https://github.com/prrrnd/atom-git-projects/issues/8#issuecomment-76911703 .
Is there a reason there are no activationEvents? There are a lot of requires and the load time is 470 ms, which is the slowest of my 40 or so packages.