search

prscX / react-native-app-tour

React Native: Native App Tour Library
Apache License 2.0
640 stars 119 forks source link

fix(android): remove status bar color changing #107

Closed kirillpisarev closed 2 years ago

kirillpisarev commented 4 years ago

What was the reason to use AlertDialog instead of Activity? Using AlertDialog leads to status bar changes color to black:

black

but with the Activity everything seem to be fine and status bar keeps a defined color:

normal

Any hidden pitfalls?

prscX commented 4 years ago

Thanks @kirillpisarev for adding the effort and sharing PR.

As per my understanding earlier it was implemented using Activity itself, but I guess folks have faced issues and was changed in PR: 4.

Thanks </ Pranav >

prscX commented 2 years ago

Thank you @kirillpisarev for the Effort and PR.

Post giving a detailed thought, I agree and understand that we should not use Dialog to show the app tour. It basically changes the status bar behavior. I am will be merging your PR.

Thanks, Pranav