search

prscX / react-native-app-tour

React Native: Native App Tour Library
Apache License 2.0
640 stars 119 forks source link

Enabling transparentTarget in Android #49

Open witalobenicio opened 6 years ago

prscX commented 6 years ago

Thanks @witalobenicio for the PR and Effort.

I have tested the same and identified that if target views are within deep hierarchy then the tour is not rendering. However the same works with .forBounds API.

Due to the same problem, I earlier changed it from .forView to .forBounds.

Please suggest. I believe we can't merge the PR since it is not working for few views.

Thanks </ Pranav >

witalobenicio commented 6 years ago

@prscX I've tested in my project, and until now, I've got no problems. For now, I'll be using my fork. If something wrong happen I'll let you know. But it would be nice if you take a look at the error prevention (when view was added to apptour and then removed from view hierarchy).