BUG FIX: Wrong icon names in example App.js for facebook and instagram

prscX / react-native-bottom-action-sheet

React Native: Native Bottom Action Sheet

Apache License 2.0

633 stars 48 forks source link

Closed mayuroks closed 5 years ago

mayuroks commented 5 years ago

BUG FIX: Wrong icon names in example App.js for facebook and instagram

prscX commented 5 years ago

Thanks @mayuroks for sharing the PR and Effort. I appreciate your observation for the same.

It was done intentionally to cover all the use cases:

facebook.png: will render icon by looking up in iOS/Android native resources.
empty: empty is to verify that if we not provide icon it should work as expected.

Thanks </ Pranav >