prscX / react-native-bottom-action-sheet

React Native: Native Bottom Action Sheet
Apache License 2.0
633 stars 48 forks source link

Icons pixelated with poor quality #34

Closed fgagneten closed 5 years ago

fgagneten commented 5 years ago

I've just downloaded the example project and it turned out that icons have a poor quality. (I will not paste code because is the same as the example project)

Info SO: Android Brand: Samsung S9 Version: 9.0 react-native Version: 0.58.6 react-native-bottom-action-sheet Version: 0.0.19 screenshot_20190305-194916_dondejuego

Is there any solution for that?

Thanks!

prscX commented 5 years ago

Thanks @fgagneten for raising the issue.

It is a know concern. Earlier I did looked into the same, but I was not able to fix the issue. If anyone found a fix please share the same.

Thanks </ Pranav >

fgagneten commented 5 years ago

I think one of the problem is related to the library: BottomSheetBuilder

I made a pull request in BottomSheetBuilder project so we can fix a piece of the problem Pull Request #40

prscX commented 5 years ago

Thanks @fgagneten for the Effort and PR.

I have created a native library fork and push the release with the fix. Could you please download latest version and verify the same.

Please let me know in case you still face the issue.

v0.0.20

Thanks </ Pranav >

fgagneten commented 5 years ago

Worked like a charm! Before 01 Before 01

After 01 after 01

Before 02 before 02

After 02 after 02

Good coding!

helenamcfreire commented 5 years ago

I'm still having this issue. Tried icons from Material and Font Awesome, and it always get pixelated. I'm already on v0.0.20.

My code:

let importIcon = <MaterialIcons name={'cloud-upload'} color={'#706E70'} size={10} family={'MaterialIcons'} />
            let exportIcon = <MaterialIcons name={"cloud-download"} color={"#706E70"} size={10} family={"MaterialIcons"} />

            let SheetView = RNBottomActionSheet.SheetView
            SheetView.Show({
                title: "Choose...",
                items: [
                    { title: "Import", value: "import", subTitle: "Import Description", icon: importIcon},
                    { title: "Export", value: "export", subTitle: "Export Description", icon: exportIcon},
                ],
                theme: "light",
                selection: 3,
                onSelection: (index, value) => {
                    // value is optional
                    console.log("selection: " + index + " " + value);
                }
            });
        }

Screenshot:

image

Info SO: Android Brand: Motorola Version: 7.0 react-native Version: 0.57.4 react-native-bottom-action-sheet Version: 0.0.20