prscX / react-native-photo-editor

React Native: Native Photo Editor
Apache License 2.0
1.12k stars 244 forks source link

Cannot read propert 'Edit' of undefined #76

Closed AhmedAliIbrahim closed 4 years ago

AhmedAliIbrahim commented 5 years ago

Hello, I've installed the package and everything is working fine on Android, but on iOS i keep getting Cannot read propert 'Edit' of undefined is there a way to fix this ?

I'm using RN 0.60

vinpro24 commented 5 years ago

I also have same issue. Did you fix it?

vinpro24 commented 5 years ago

Hello, I've installed the package and everything is working fine on Android, but on iOS i keep getting Cannot read propert 'Edit' of undefined is there a way to fix this ?

I'm using RN 0.60

Any idea to resolve?

se09deluca commented 5 years ago

Same situation in iOS on React Native 0.60.4. Any help?

j0araya commented 5 years ago

same issue here. installation change?

I updated react from a new clean install and this package is the last one that i need, worked ok on android.

"react": "16.8.6", "react-native": "0.60.5",

thnks.

NateOelke commented 5 years ago

I am having this same problem with both React Native 0.6 and 0.61. It looks like the npm package has not been updated in 10 months and does not include more recent PRs.

prscX commented 4 years ago

Thanks for raising issue.

We weeks back I have enabled support for RN61 >=. Could you please migrate your project to RN61 and install latest version of library. Please follow installation steps for the same.

Let me know incase you still face the same issue.

P.S: RN60 not support by the latest version since RN60 has limitation of using use_framework! .

Thanks </ Pranav >

JerakRus commented 4 years ago

Hello! I am use: react-native: 61.5 react-native-photo-editor: 1.0.5 from npm And have this error. Can you help me?

prscX commented 4 years ago

Could you share your pod file, please.

JerakRus commented 4 years ago

@prscX , Despite the fact that it did not conflict with firebase as I saw in other issues, it was built without errors, and the application worked fine, except for this error.

 platform :ios, '9.0'
 require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'myApp' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  use_frameworks!
  use_native_modules!

  pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/'
  pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
  pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'ReactCommon/jscallinvoker', :path => "../node_modules/react-native/ReactCommon"
  pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
  # Pods for insales_mobile
  pod 'Fabric', '~> 1.10.1'
  pod 'Crashlytics', '~> 3.13.1'
  pod 'Firebase/Core', '~> 6.3.0'
  pod 'Firebase/RemoteConfig', '~> 6.3.0'
  pod 'Firebase/Messaging', '~> 6.3.0'
  pod 'Firebase/Analytics', '~> 6.3.0'
  pod 'Firebase/Performance', '~> 6.3.0'
  pod 'RSKImageCropper'
  pod 'QBImagePickerController'
  pod 'GoogleIDFASupport', '~> 3.14.0'
  pod 'YandexMobileMetrica', '~>3.7.1'
  pod 'Toast', '~> 4.0.0'

  pod 'RNPhotoEditor', :path => '../node_modules/react-native-photo-editor/ios'
  pod 'iOSPhotoEditor', :git => 'https://github.com/prscX/photo-editor', :branch => 'master'
  post_install do |installer|
    installer.pods_project.targets.each do |target|
      if target.name.include?('iOSPhotoEditor')
        target.build_configurations.each do |config|
          config.build_settings['SWIFT_VERSION'] = '5'
        end
      end
    end
  end

  target 'myAppTests' do
    inherit! :search_paths
    # Pods for testing
  end
end

target 'myApp-tvOS' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for myAppOS

  target 'myApp-tvOSTests' do
    inherit! :search_paths
    # Pods for testing
  end

end
prscX commented 4 years ago

Thanks for sharing Podfile. Could you please try adding both RNPhotoEditor and iOSPhotoEditor separately in use_native_module and use_frameworks section. At a quick glance I am able to see this difference compared to example project. I am not sure if this solves the issue.

Please give a try and let me know how it goes.

prscX commented 4 years ago

Also could you please try running example project, if it works there I don't see a challenge of not working here. Let's see how it goes.