search

prscX / react-native-shine-button

React Native: Native Shine Button - Effects like shining
Apache License 2.0
356 stars 37 forks source link

Add Custom icon #4

Closed afsadilson closed 6 years ago

afsadilson commented 6 years ago

How can I add some new icons to this lib?

prscX commented 6 years ago

Thanks @afsadilson for the enhancement request.

I have enabled the support for custom icon using react-native-vector-icons. Please install latest version and follow README steps in order to use the same.

Let me know in case you face any issues.

Note: Currently android library is tagged to my fork, once ChadCSong/ShineButton: 37 is merged I will relocate the tag.

Thanks </ Pranav >

afsadilson commented 6 years ago

Hi,

First of all, thanks for your work. I'm facing an issue after this new release, my icons are kind of a blurry seems like they are badly dimensioned.

Before ShineButton component they was made with Icon component made by native base and using Ionicons set. If you look at official Ionicons page, you'll see the bookmark icon, for example, is thinner.

I think the problem is the size property at RNShineButton, because I was using Icon component with style "fontSize:20" and was fine, now I can't use fontSize anymore.

I hope I was clear.

2b60861f-548c-4b74-a045-ecd0b31df215