prscX / react-native-shine-button

React Native: Native Shine Button - Effects like shining
Apache License 2.0
356 stars 37 forks source link

default value not start with correct color #6

Closed callmejm closed 6 years ago

callmejm commented 6 years ago

Thank again for making this awesome library. Bellow is the shine button I made:

<RNShineButton shape={"heart"} color={"#ffffff"} fillColor={"#FF6C6C" } size={70} value={true}
  onChange={(isLike)=> this._Vibration(isLike)}/>

So, my default value of shine button are true , but the button are start with color of #ffffff, if the default value is true color should start with the fillColor #FF6C6C , hope can make this changes, thanks a lot

prscX commented 6 years ago

Thanks @JayricMok for raising the issue.

I have found the root cause and fixed the same. Can you please install latest v0.0.5 and verify the same.

Please let me know in case you still face the same issue.

Thanks </ Pranav >

ragone commented 6 years ago

I am still seeing this issue on version 0.0.7 - could we reopen this please @prscX ?

prscX commented 6 years ago

@ragone: That's strange. I will validate the same.

Thanks for the update

Thanks </ Pranav >

callmejm commented 6 years ago

I update to v0.0.5 last week, it work

prscX commented 6 years ago

Thanks @JayricMok for verification.

Hi @ragone,

Just now I have released V0.0.8 and verified it is working as expected. Please find below screenshot of the same:

screen shot 2018-04-22 at 1 18 45 pm

Can you please verify the installed version of react-native-shine-button

Thanks </ Pranav >

prscX commented 6 years ago

Hi @ragone + @JayricMok,

Hope it is working for you post upgrading the module. Can I please close the issue?

Thanks </ Pranav >