Closed aMarCruz closed 5 years ago
Thanks a lot @aMarCruz for pointing out the issue.
Completely my bad. Please let me know in case you are looking to raise a PR else I can do the required changes in order fix it.
Thanks </ Pranav >
@prscX , just now I'm working in a local fork of your repo, fixing a strange issue with the Android API. I need to finish my current project this week, but after that I will gladly contribute fixing this new issue. Thanks
@prscX , thanks for your great work.
Looking at the JS code I see this block stating at line 72 of RNTooltips.js:
If the intention is to test each value, the correct code would be:
...otherwise the chain will break with the first equality, ex. if both
position
andalign
are undefined, onlyposition
will get the default.In the other hand, React and React native already sets automatically default values with the static
Tooltips.defaultProps
property, sothese block is not necessary(EDIT: sorry, Show is static as well).