Closed StevenMasini closed 5 years ago
Thanks a lot @StevenMasini for sharing the valuable feedback.
pod install
: I have added the auto installation to my other libraries. Probably coming weekend I can add the same to this library as well. Please refer react-native-app-tour for the same.Thanks </ Pranav >
@prscX Well actually it's harder than I thought ^^
SexyTooltips has only two files, but it as a dependency over Facebook pop, which is not a small dependency.
Actually if we didn't have to use our own fork for SexyTooltip to change the type of the delegate from weak
to strong
, we could have just make a .podspec
and ask developers to add the pod via relative path to their Podfile
.
I need to dig deeper into the source code to see if there is not a solution for onHide
to be called even though the native tooltip has been killed.
Hi @StevenMasini: I have pushed a release by including auto pod installer
on npm install
.
Please let me know incase does not works.
Thanks </ Pranav >
Hi @prscX,
Thanks for building this library, it's great!
I just would like to suggest to update the way the iOS part is setup. Right now you need to run
pod install
in the project foldernode_modules/react-native-tooltips/ios
.It's not super convenient as you need to run this command every time you re-build, and it force you to add a specific rule to your CI/CD script to handle this case.
I already had a look at the project source, you made your own fork of SexyTooltip and change the delegate from
weak
tostrong
. I guess that's because the delegate wasn't kept alive long enough for your framework.Anyway, SexyTooltip is contained in two file. I would like to suggest to move these two files directly in the
react-native-tooltips
repository. This way we don't need to runpod install
anymore.Also we can update the
RNTooltips.podspec
in order to give two options for developers to add the library to their project.What do you think ? I am open to other suggestion too.