prudhvitella / terraform-provider-infoblox

Infoblox plugin for Terraform
Mozilla Public License 2.0
41 stars 54 forks source link

upgrade to TF .12 #49

Open on4tux opened 5 years ago

on4tux commented 5 years ago

according to https://www.terraform.io/upgrade-guides/0-12.html#upgrading-terraform-providers, .11 providers need to upgraded to work with TF .12

GraemeKnights commented 5 years ago

I second this as being very desirable if somebody can manage it please? :) No idea how much work is involved...

RobCannon commented 5 years ago

I have converted this to support terraform v0.12. I have one pull request that needs to be merged first, and then a second PR that builds on top of that.

RobCannon commented 5 years ago

Plus, I have support for using the new VS Code container build technology. You don't have to worry about what version of Go you have installed locally (or you don't even need it installed!). The container defines the development environment. It works pretty well. So, two more PR's waiting once #56 is accepted.

JackBracken commented 5 years ago

Thanks @RobCannon Give me a few hours while I catch up to the other issues and PRs and I'll test. :)

surskitt commented 5 years ago

Apologies for asking both on here and the pull request, but is this still being considered? Would be really nice to have the provider working with terraform 0.12

codyja commented 5 years ago

Looking forward to this PR also! Thanks

zackhorvath commented 5 years ago

Currently in this boat as well - love the plugin!

pescetto commented 5 years ago

@RobCannon @prudhvitella You know if that PR is still open? I don't see it in there and I didn't see it being merged. Just hoping to get this provider updated soon. Thanks to all the contributors who've worked on this!

RobCannon commented 5 years ago

56 is still open. I have moved onto another company, so i can't really test this module any more. I have the checkins and can submit them as PRs once #56 is committed, but I can't really support them.

pescetto commented 5 years ago

@prudhvitella any time frame on this if possible?

surskitt commented 5 years ago

@RobCannon you mentioned you can't support, would this mean you're not willing and/or able to create a fork and merge both of your pull requests into it?

RobCannon commented 5 years ago

My code is all here: https://github.com/RobCannon/terraform-provider-infoblox

There are three branches, one supports modules, one is the update for terraform 0.12 and the third branch adds support for using vscode remote docker support (very handy to make sure all the right requirements are there for building).

surskitt commented 5 years ago

Thanks a lot @RobCannon . So do I just need to merge them on top of each other?

RobCannon commented 5 years ago

They are all branched from each other. So the vscoderemote has all of the changes.

surskitt commented 5 years ago

@RobCannon I've built from your branches and it all works great! I feel bad for taking so long to thank you.

All the more reason to get these PRs merged.

ooOOJavaOOoo commented 5 years ago

@prudhvitella any feedback on merging these?

RobCannon commented 5 years ago

@ooOOJavaOOoo Sorry, I am not familiar "license acceptance error".

ooOOJavaOOoo commented 5 years ago

@RobCannon sorry, had too many github threads going, getting the nul block error

Error: Provider produced invalid plan

Provider "infoblox" planned an invalid value for module.infoblox_linux.infoblox_record_host.general[0].ipv6addr: attribute representing a list of nested blocks must be empty to indicate no blocks, not null.

Using terraform 0.12.8

RobCannon commented 5 years ago

Sorry, that it why I can't really support this. I don't have access to an F5 to try to replicate the issue.

Plus, I don't think that issue is a result of my changes. I didn't really make any changes to the core code. It might be due to a change in terraform types, through.

wenesak commented 3 years ago

How do you compile this provider?