lshachar
commented
5 years ago Hi Baptiste, I see that in aa9d997822746be28f4f0cfbc94a897504288c03 You implemented the variable sinking beep, but not the variable climbing beep. I wonder if you tested it and were just unhappy with the change, or for any other reason? My patch did not break or changed the previous behaviour, but it added functionality - being able to set a climbing beep that is varying in frequency during a beep, or keeping the monotonous beep. I think many (if not most?) varios use a varying frequency beep. and I find it a lot more informative as I don't need to wait for the next beep to understand the variance in climb rate since the current beep started. Do you think otherwise? let me know, I can fix the conflicts if you are interested in re-testing.
The sinking beep was programmed as a set value, which was played for every sinking rate above the sinking threshold. with this commit, the user can configure the sinking beep as it were before (fixed sound: change SINKING_BEEP_FREQ_UPDATE 0 in beeper.h) or set a sink sound update frequency in milliseconds. (currently set to 1 - change smoothly and rapidly)
Similarly, The Climbing beep was played at a fixed pitch. by changing the climbing beep frequency as it is playing, one gets a lot more information what the vario is doing. User can set this up the same way, with CLIMBING_BEEP_FREQ_UPDATE.