search

prunkdump / arduino-variometer

Arduino based variometer with accelerometer, screen, gps and sdcard code
GNU General Public License v3.0
84 stars 40 forks source link

Variable Climbing sound #33

Open lshachar opened 4 years ago

lshachar commented 4 years ago

Hi Baptiste, I see that in aa9d997822746be28f4f0cfbc94a897504288c03 You implemented the variable sinking beep, but not the variable climbing beep. I wonder if you tested it and were just unhappy with the change, or for any other reason? My patch did not break or changed the previous behaviour, but it added functionality - being able to set a climbing beep that is varying in frequency during a beep, or keeping the monotonous beep. I think many (if not most?) varios use a varying frequency beep. and I find it a lot more informative as I don't need to wait for the next beep to understand the variance in climb rate since the current beep started. Do you think otherwise? I made a branch that merges with no errors for you to test. please note that for your default behavior you need to change the #define CLIMBING_BEEP_FREQ_UPDATE back to 0.

#define CLIMBING_BEEP_FREQ_UPDATE 1 // update climbing beep frequency(pitch) after X milliseconds. 0 = monotonous beep, do not update frequency while beep is playing. 1 = pitch changes smoothly every 1ms. more than 1 = pitch changed in steps every X milliseconds.

sepi commented 3 years ago

I just tested it without flying and I like it. I would still export the setting into VarioSettings.h so that the end-user can easily configure it.

lshachar commented 3 years ago

That's not a bad idea! I guess I put it in beeper.h because that's where the other sound settings were. anyhow it's up to @prunkdump to decide ;)