search

prunycb / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Fancybox x 2 (improvement) #299

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1. Initial Edit X menu is out of place

2. The width of "Edit" menu item is wrong. Should sit next to Edit when 
collapsed.

3. Save button makes full width of fancybox clickable for some reason. 

4. Fancybox in Edit mode has Save button. Pressing it does CROP when no crop 
was even clicked in the menu. There was nothing to save at all.
Save button should only be there when there is anything to save. It just sits 
there all the time. It's confusing. E.g. no need to save anything after Rotate.

5. Doing CROP in EDIT mode shows a cropped thumb (replicate: crop, save, 
restore, close).

6. Edit / fit menu should collapse on selection or on loosing focus to 
something else. E.g. I click elsewhere on the page.

7. "Use triggers to ..." -> "Select visible part" (translations).

8. Edit/fit menu won't collapse at all after closing fancybox (clicked save). 
Menus on other imgs won't expand either.

9. Reset metadata for an image if it was cropped/rotated/restored thru EDIT.

10. Crop handles get "stuck". I release mouse button, but the crop box still 
moves.

11. No tool-tip for [?]

12. Image reso never gets under placeholder reso even when it is.

13. No warning when image reso < placeholder reso

Original issue reported on code.google.com by igor.sni...@gmail.com on 3 Sep 2010 at 2:23

GoogleCodeExporter commented 9 years ago

Original comment by igor.sni...@gmail.com on 3 Sep 2010 at 2:30

GoogleCodeExporter commented 9 years ago 
10: The OnMouseUp event is definetely not fired. It is 100% javascript error. 
Probably occured when something was not completly loaded on the page.

Original comment by igor.sni...@gmail.com on 3 Sep 2010 at 2:30

GoogleCodeExporter commented 9 years ago 
11: What should be displayed by this tool-tip? Design, content ...

Original comment by igor.sni...@gmail.com on 3 Sep 2010 at 2:32

GoogleCodeExporter commented 9 years ago 
12,13: It depends on whether place holder type is "powerclip" or not. And it 
works.

Original comment by igor.sni...@gmail.com on 3 Sep 2010 at 2:35

GoogleCodeExporter commented 9 years ago 
14. Opened, closed image editing. Clicked X to delete the image. Had to click 
CANCEL 5 times for some reason.

Original comment by igor.sni...@gmail.com on 3 Sep 2010 at 2:41

GoogleCodeExporter commented 9 years ago 
3, 4: Fixed.
rev: http://code.google.com/p/magento-w2p/source/detail?r=997

Original comment by igor.sni...@gmail.com on 6 Sep 2010 at 11:48

GoogleCodeExporter commented 9 years ago 
6, 8: Fixed.
rev: http://code.google.com/p/magento-w2p/source/detail?r=995

Original comment by igor.sni...@gmail.com on 6 Sep 2010 at 11:50

GoogleCodeExporter commented 9 years ago 
7: Fixed.
rev: http://code.google.com/p/magento-w2p/source/detail?r=996

Original comment by igor.sni...@gmail.com on 6 Sep 2010 at 11:50

GoogleCodeExporter commented 9 years ago 
1, 2: moved to Issue 300.

Original comment by igor.sni...@gmail.com on 6 Sep 2010 at 11:51

GoogleCodeExporter commented 9 years ago 
14: gone after previous bug fixing

Original comment by igor.sni...@gmail.com on 6 Sep 2010 at 11:53

GoogleCodeExporter commented 9 years ago 
9: Fixed.
rev: http://code.google.com/p/magento-w2p/source/detail?r=998

Original comment by igor.sni...@gmail.com on 7 Sep 2010 at 12:38

GoogleCodeExporter commented 9 years ago 
5: could not reproduce this problem. Seems to be works fine

Original comment by igor.sni...@gmail.com on 7 Sep 2010 at 12:44

GoogleCodeExporter commented 9 years ago 
Deployed on MageImage,
Please note that problems 1 and 2 from list above moved to Issue 300.

Original comment by igor.sni...@gmail.com on 7 Sep 2010 at 12:54

GoogleCodeExporter commented 9 years ago

Original comment by igor.sni...@gmail.com on 8 Sep 2010 at 11:08

GoogleCodeExporter commented 9 years ago 
SVN (the latest bugfixing):
http://code.google.com/p/magento-w2p/source/detail?r=1019
http://code.google.com/p/magento-w2p/source/detail?r=1020
http://code.google.com/p/magento-w2p/source/detail?r=1021

Deployed:
MageImage

Original comment by igor.sni...@gmail.com on 9 Sep 2010 at 1:44

GoogleCodeExporter commented 9 years ago 
Product name that would be usefull for testing: "Image edit test, x5, pc-non-pc 
variations" in "New 2010-09-07" category.

Original comment by igor.sni...@gmail.com on 9 Sep 2010 at 1:48

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
adjust fancybox size when messages appear in InfoBar

SVN:
http://code.google.com/p/magento-w2p/source/detail?r=1022

Deployed:
MageImage

Original comment by igor.sni...@gmail.com on 9 Sep 2010 at 3:15

GoogleCodeExporter commented 9 years ago 
Tested on:
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/new-2010-0
9-07/image-edit-test-x5-pc-non-pc-variations.html
in FF, IE and Chrome.

New-1. FancyBox totally falls apart in IE and Chrome. Try opening Edit mode and 
cropping. Fancybox gets stretched.

3. and 4. - Test OK

5. This is what happens when I try it: 
Cropped, saved, closed the FancyBox. Thumb is cropped (zoomed)
Fancybox - crop_edit_mode_fb_01.png
Scroll - crop_edit_mode_scroll_01.png
Unless there are some changes to the behavior, I think it works fine.

6. Test OK in FF.
Not fixed in IE and Chrome.

7. Edit and Fit crop mode notification is changed from:
"Use triggers to crop image"
to
"Select visible part to crop image"
Should be "Select visible part" only.

8. Test OK in FF.
Not fixed in IE and Chrome.

9. How do I test?

10. Open FIT mode. Drag from one corner to the other one. Release the mouse 
click only after the cursor goes outside the image area. Move the mouse around 
(with the click released). Cropping is still active.

11. Lets try this for now (tool_tip_1-1.png)

12. Test OK.

13. I see the warning. Test OK.

14. Test OK

Original comment by agur...@gmail.com on 9 Sep 2010 at 12:18

Attachments:

GoogleCodeExporter commented 9 years ago 
New-1) fixed.

6, 8) fixed for IE and Chrome.

7) fixed.

10) it is JCrop implementation problem itself.

9) open "Edit & save", rotate or crop image, close fancybox. Crop box should 
disappear on this thumb. Open "Fit in field" - crop box for image preview 
should be default.

SVN:
http://code.google.com/p/magento-w2p/source/detail?r=1045

Deployed:
mageimage

Original comment by igor.sni...@gmail.com on 14 Sep 2010 at 1:13

GoogleCodeExporter commented 9 years ago 
Ignore the tooltip for now. It will be a separate task. Needs to be bundles up 
with other little improvements. Post it after testing.

Original comment by zetapri...@gmail.com on 14 Sep 2010 at 1:13

GoogleCodeExporter commented 9 years ago 
New-1 - Test OK

6. Not fixed in Chrome

7. Test OK

8. Not fixed. Replication:
- 
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/new-2010-0
9-07/image-edit-test-x5-pc-non-pc-variations.html
- FIT one image and close the fancybox
- Upload a new image and FIT it then close the fancybox.
- Edit menu doesn't work anymore

9. Not fixed. 
- Opened an image and rotated it through EDIT menu. 
- Cropped the same image through FIT menu
- Restored the image through EDIT menu
- Thumbnail was no longer cropped but when I went to FIT the image, the crop 
selection box was not the default one. Crop selection was positioned as my last 
crop that I did before (though the FIT menu). If I understand correctly, my 
EDIT menu changes were suppose to reset the "FIT" crop box to its default 
value. They did not.

Original comment by agur...@gmail.com on 14 Sep 2010 at 11:21

GoogleCodeExporter commented 9 years ago 
6.

SVN diff:
http://code.google.com/p/magento-w2p/source/detail?r=1063

Original comment by igor.sni...@gmail.com on 21 Sep 2010 at 11:56

GoogleCodeExporter commented 9 years ago 
6. addition

SVN diff:
http://code.google.com/p/magento-w2p/source/detail?r=1064

Original comment by igor.sni...@gmail.com on 22 Sep 2010 at 12:05

GoogleCodeExporter commented 9 years ago 
8.

SVN diff:
http://code.google.com/p/magento-w2p/source/detail?r=1065

Original comment by igor.sni...@gmail.com on 22 Sep 2010 at 12:22

GoogleCodeExporter commented 9 years ago 
bugfix (edit menu didn't work after thumb cropbox appearing)

SVN diff:
http://code.google.com/p/magento-w2p/source/detail?r=1066

Original comment by igor.sni...@gmail.com on 22 Sep 2010 at 12:56

GoogleCodeExporter commented 9 years ago 
9.

SVN diff:
http://code.google.com/p/magento-w2p/source/detail?r=1068

Original comment by igor.sni...@gmail.com on 22 Sep 2010 at 5:01

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 12 Nov 2010 at 2:18