search

prunycb / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Get rid of REL attr for storing shape names #628

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Decision to use REL attr for storing shape names is bad. Blame me.

According DTD value of REL attr has URI data type. So using this attr for 
storing shape names with spaces and some other symbols produces errors is some 
cases (jQuery's selectors, for example).

The code should be updated to use TITLE attr instead REL one to avoid such 
errors.

Original issue reported on code.google.com by Anatoly....@gmail.com on 11 Aug 2011 at 10:27

GoogleCodeExporter commented 9 years ago 
We need a testing plan for this.
What exactly is going to be affected?

Let's look at the diff and decide on the amount of testing.

Original comment by ad...@zetaprints.com on 11 Aug 2011 at 10:33

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 11 Aug 2011 at 10:43

GoogleCodeExporter commented 9 years ago 
Diffs:

 * http://code.google.com/p/magento-w2p/source/detail?r=1770
 * http://code.google.com/p/magento-w2p/source/detail?r=1771
 * http://code.google.com/p/magento-w2p/source/detail?r=1772

Original comment by Anatoly....@gmail.com on 11 Aug 2011 at 11:57

GoogleCodeExporter commented 9 years ago 
Please, test it with 1.9.1.0alpha17 release.

Just check that shapes part of the interface works as expected.

Original comment by Anatoly....@gmail.com on 15 Aug 2011 at 1:46

GoogleCodeExporter commented 9 years ago 
Not clear on the testing. 
Are you saying that I should just check if the highligher shapes overlaying the 
preview image are not misaligned or distorted in some way?

Original comment by agur...@gmail.com on 16 Aug 2011 at 2:11

GoogleCodeExporter commented 9 years ago 
No, I mean testing in-preview editing.

Original comment by Anatoly....@gmail.com on 16 Aug 2011 at 2:31

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha18 (alpha)

1. When access through the highlighter, image editing FancyBox shows the 
"Update preview" half of the button in the corner (image_editor.png).
- go to: 
http://d1.zetaprints.com/mageimage/index.php/magentot-01/2pg-template.html
- click on the image in the preview image to get the InPrev editor form
- upload some image in your image library and click on its thumb
- you should see the FancyBox for the image editor with the "Update preview" 
button in the corner

2. Wasn't able to activate FitInField feature using the custom-options.xml 
file. So, that part is not tested.

Original comment by agur...@gmail.com on 16 Aug 2011 at 3:41

Attachments:

GoogleCodeExporter commented 9 years ago 
> 2. Wasn't able to activate FitInField feature using the custom-options.xml 
file.
> So, that part is not tested.

It seems you did smth wrong.

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 6:13

GoogleCodeExporter commented 9 years ago 
> 1. When access through the highlighter, image editing FancyBox shows the 
"Update
> preview" half of the button in the corner (image_editor.png).

Fixed. Diff: http://code.google.com/p/magento-w2p/source/detail?r=1777

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 6:30

GoogleCodeExporter commented 9 years ago 
Please, re-test it with 1.9.1.0alpha19 release.

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 8:12

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha19 (alpha)

Looks pretty buggy to me. Here's what happened:
1. This is the original image (fb_01.png)
2. This is what I cropped it to (fb_02.png).
3. This is the FitInField crop I did to it (fb_03.png).
4. This is what the thumb looks like after I hit "Save" (fb_04.png) notice it 
is not according toe the FitInField I just did.
5. The updated preview looks ok (fb_05.png)
6. This is what I see when I re-open the FancyBox for the image (fb_06.png).

Original comment by agur...@gmail.com on 17 Aug 2011 at 5:29

Attachments:

GoogleCodeExporter commented 9 years ago 
Heh, sorry Atanas. I confused you :-(

You should test in-preview editing part of the interface (shapes and fields 
highlighting, pop-up editor).

You tested image editing stuff which hasn't been finished yet and is switched 
off by default.

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 7:05

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha19 (alpha)

Original comment by agur...@gmail.com on 18 Aug 2011 at 10:33

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 18 Aug 2011 at 11:39