search

prusa3d / Prusa-Firmware-Buddy

Firmware for the Original Prusa MINI, Original Prusa MK4 and the Original Prusa XL 3D printers by Prusa Research.
Other
1.13k stars 218 forks source link

Improve UI message when loading filament #1702

Closed joneuhauser closed 3 months ago

joneuhauser commented 2 years ago

Please, before you create a new bug report, please make sure you searched in open and closed issues and couldn't find anything that matches. (Tangentially related: https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/260)

Printer type - [MINI]

Printer firmware version - [4.3.3]

Original or Custom firmware - [Original]

Optional upgrades - [Filament Runout Sensor]

USB drive or USB/Octoprint - [USB]

Describe the bug

When changing filament, it prompts to "Press CONTINUE and push filament into the extruder." (https://github.com/prusa3d/Prusa-Firmware-Buddy/blob/master/src/gui/dialogs/DialogLoadUnload.cpp#L24). However, the filament needs to be inserted (touching the extruder gears) before pressing continue, because pressing continue rotates the extruder gears.

How to reproduce Load filament.

Expected behavior The message should be "Push filament into the extruder and press CONTINUE.".

mtaumike commented 2 years ago

ha! I never caught this before! Good job!

zoltan-l commented 2 years ago

It is not really a programming bug, I would see it as guidance enhancement , but a very good one. let us see!

PiorGit commented 2 years ago

Just wanted to confirm that this is indeed quite annoying, as I cannot see how a new user could ever guess the proper order of operations. The suggestion by the OP is very simple yet it would be enough to fully address the issue.

@zoltan-l Well, it isn't so much a mere guidance enhancement, since the current instruction state literally the opposite of what one should do :D The current text is straight up erroneous.

TheOneTrueRazor commented 2 years ago

It is not really a programming bug, I would see it as guidance enhancement , but a very good one. let us see!

Instructing people the right way to do a procedure is an "enhancement"? 🤔 Sorry, @zoltan-l this issue is a lot closer to being a bug than it is an enhancement. Maybe if it were labeled as such, this very simple "fix" would have at least been assigned to someone by now.

PiorGit commented 2 years ago

@TheOneTrueRazor Unfortunately this kind of miscommunication happens all the time in software development : Users report a UX issue using the only means at their disposal (a bug tracker), an engineer then (rightfully) replies that "this isn't a bug" (because of course it isn't one, since there is no functional code to fix) ... and the issue remains unassigned and unresolved.

This should probably be flagged as "UI" rather than "enhancement".

Prusa-Support commented 2 years ago

Hello! Thank you for the comments and sorry for the late response from my side. I labelled the issue as UI related and brought it to our devs attention.

Alessandro Pantaleo Prusa Research

PiorGit commented 2 years ago

That's appreciated ! Much thanks.

By the way, on this very same screen there is also a header and a sub header saying : FILAMENT LOAD FILAMENT

This really doesn't make sense or perhaps it is broken English from a bad translation - as "Load filament" sounds like an instruction to the user, whereas here it really is just a menu title. I believe that this should be changed to a more accurate description, like : FILAMENT OPERATION : LOADING OF NEW FILAMENT

(I am mentioning broken English because I just saw the same kind of grammatical confusion on a French git where commit titles where written in the exact same kind of approximate grammar. This leads me to believe that the Mini/Mini+ menus were probably not designed by someone fully fluent in English).

On a more general note I think it is worth noting that menu hierarchies don't necessarily need to be shown at all times. Sometimes hiding them can be much more clear.

TheOneTrueRazor commented 2 years ago

@TheOneTrueRazor Unfortunately this kind of miscommunication happens all the time in software development : Users report a UX issue using the only means at their disposal (a bug tracker), an engineer then (rightfully) replies that "this isn't a bug" (because of course it isn't one, since there is no functional code to fix) ... and the issue remains unassigned and unresolved.

This should probably be flagged as "UI" rather than "enhancement".

"UI" is great suggestion. 👍

Prusa-Support commented 2 years ago

Hello! Thank you for the additional suggestions, I brought these also to our devs attention. In case of anything in the meantime, both suggestions or anything to review that can be related, do not hesitate to add them with further comments.

Alessandro Pantaleo Prusa Research

PiorGit commented 2 years ago

Hello Alessandro ! Great to hear that it is being considered.

FWIW there is still an ongoing discussion going on on the topic on the public forum - which, as one would expect, lead to some users claiming that the instructions are 100% correct as they are, and that the user should be bright enough to figure out the correct (reverse) order :D That's interesting to me because it shows precisely the kind of thinking that must have lead to the ambiguous instructions in the first place (ie thinking of them like a programmer, as opposed to thinking of them like a UX designer).

https://forum.prusa3d.com/forum/general-discussion-announcements-and-releases/the-instructions-for-filament-change-are-incorrect-as-they-are-presented-in-reverse-order/#post-620219

github-actions[bot] commented 3 months ago

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

github-actions[bot] commented 3 months ago

This issue has been closed due to lack of recent activity. Please consider opening a new one if needed.