search

prusa3d / Prusa-Firmware-Buddy

Firmware for the Original Prusa MINI, Original Prusa MK4 and the Original Prusa XL 3D printers by Prusa Research.
Other
1.15k stars 221 forks source link

[BUG] Filament Change (german version) shows [J ][MEH] statt [Ja][nein] #3611

Closed MagWolfgangPraxl closed 1 month ago

MagWolfgangPraxl commented 9 months ago

Please, before you create a new bug report, please make sure you searched in open and closed issues and couldn't find anything that matches.

Prusa MINI+ - [MINI]

5.1.2 - [e.g. 4.0.5, ...]

Original - [Original/Custom]

Filament Runout Sensor - [e.g. Filament Runout Sensor]

USB/Octoprint Please let us know if you print via USB flash drive or USB/Octoprint

Filament Change (german version) shows [J ][MEH] statt [Ja][nein] A clear and concise description of what the bug is.

Go to "Filament Change (german version)" -- follow instructions Please describe steps to reproduce the behavior.

Is Filament clean -- [Ja][nein] A clear and concise description of what you expected to happen.

bkerler commented 9 months ago

Can you please upload a picture ? This way it's easier to see if that's a translation issue or a bug. Update: Not needed anymore. See below.

bkerler commented 9 months ago

I assume this screen: image

bkerler commented 9 months ago

That's a translation issue / Screen layout issue: It should say "JA", "MEHR", "WIEDERHOLEN". By shortening "WIEDERHOLEN" to "WDH.", the screen would look like this:

image

Would this be acceptable (Would be easiest to fix) ?

MagWolfgangPraxl commented 9 months ago

Hi, I’m sorry, the printing still takes about 2 hours before I can deliver some fotos. But you are right. It is acceptable for me.

The [J ][MEH] looked for me like a glitch or internal disorder.

With kind regards - Mag. Wolfgang Praxl

Am 2023-12-18 um 23:12 schrieb Bjoern Kerler @.***>:

That's a translation issue / Screen layout issue: It should say "JA", "MEHR", "WIEDERHOLEN". By shortening "WIEDERHOLEN" to "WDH.", the screen would look like this:

image.png (view on web) https://github.com/prusa3d/Prusa-Firmware-Buddy/assets/6317772/edaceb65-f4b4-4f80-adb7-5205b5256b81 Would this be acceptable (Would be easiest to fix) ?

— Reply to this email directly, view it on GitHub https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3611#issuecomment-1861774010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN7IYL4HHARTBCHK3TCPSLLYKC5VTAVCNFSM6AAAAABA2AWR3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRG43TIMBRGA. You are receiving this because you authored the thread.

Th3Rom3 commented 9 months ago

That's a translation issue / Screen layout issue: It should say "JA", "MEHR", "WIEDERHOLEN". By shortening "WIEDERHOLEN" to "WDH.", the screen would look like this:

image

Would this be acceptable (Would be easiest to fix) ?

I wouldn't say that "Mehr" is the correct negative reply to the question "Farbe korrekt?". It makes sense in context but isn't technically correct. I personally would go with "Ja" "Nein" "WDH." But I guess this might break with the original software design intention.

bkerler commented 9 months ago

@Th3Rom3 Yes, exactly that was my feeling about it as well. But the way this menu was designed, it is as it is. @MagWolfgangPraxl Ok, will push a PR for it tomorrow :)

bkerler commented 9 months ago

PR #3614 has been pushed :)

github-actions[bot] commented 4 months ago

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

danopernis commented 1 month ago

New version of the firmware 6.1.2 should contain the fix, can you test that?

MagWolfgangPraxl commented 1 month ago

For me it works (firmware 6.1.2 mini-english-german) in both cases:

bkerler commented 1 month ago

@MagWolfgangPraxl can you then please close the issue if everything is fine by now ? :)