search

prusa3d / Prusa-Firmware-Buddy

Firmware for the Original Prusa MINI, Original Prusa MK4 and the Original Prusa XL 3D printers by Prusa Research.
Other
1.16k stars 229 forks source link

[BFW-5918] [ENHANCEMENT] Don't remove trailing zeroes of the Footer's axis value for static footer appearance #4042

Open puhitaku opened 4 months ago

puhitaku commented 4 months ago

Printer model

All

Describe the enhancement

Hi, thanks for the cool firmware!

The current implementation of footer items of axis position, gcode position, and live z removes trailing zero. This makes sense, for aesthetic reasons, but in reality this makes the footer items wobble around when the value is like 2.50 that will actually be 2.5 on the screen.

I personally prefer NOT removing zero since not removing it will result in constant displayed width of footer items and constant positioning. I'm ready to contribute when this idea is accepted. Thank you!

Expected functionality

No response

danopernis commented 4 months ago

Hi @puhitaku thanks for the generous offer. I talked to the product department and they like your proposal.

Before implementing it, please wait for the next minor release. The footer was recently refactored in our private fork so integrating your changes if you start developing now would involve solving a lot of git conflicts.

puhitaku commented 4 months ago

Thanks @danopernis. Then, I'll begin watching this repository for the upcoming release. Please ping me if I seem to forget here, just in case.

puhitaku commented 4 months ago

@danopernis Apologies for taking your time, but if I can know the estimated release date of the next minor release, I'd be happy

danopernis commented 4 months ago

@puhitaku I am expecting several weeks, but don't quote me on that :slightly_smiling_face: it wouldn't be the first delay I've seen in my software engineering career.

Perhaps the merge conflict wouldn't be as problematic as I was originally imagining it, so if you want to, go ahead :+1:

puhitaku commented 3 months ago

I've filed a PR for this issue (and I've invalidated the warranty of my MK4 to see if this change works haha 😁) Looking forward to seeing the upcoming review and merger!

danopernis commented 2 months ago

Thank you for the contribution. I merged your fix. Considering this is not a bugfix, this will not make it into 6.1.x, but it will be eventually released in some future release. I am keeping the issue open to track progress.