prusa3d / Prusa-Firmware-Buddy

Firmware for the Original Prusa MINI, Original Prusa MK4 and the Original Prusa XL 3D printers by Prusa Research.
Other
1.13k stars 218 forks source link

[BUG] MK4 cannot read folders copied from google drive for desktop #4131

Open 0ba-pia opened 1 month ago

0ba-pia commented 1 month ago

Printer model

MK4

Firmware version

6.0.3

Upgrades and modifications

No response

Printing from...

USB Stick

Describe the bug

Folders containing .bgcode files that are stored with google drive for desktop (windows version) and directly copied to the prusa USB stick won't be listed by the MK4 printer. Note that this works fine with MK3S printer.

How to reproduce

No response

Expected behavior

No response

Files

No response

0ba-pia commented 1 month ago

I found out that to make it work you have to remove the "desktop.ini" files that are created by google drive at the root of each folder.

danopernis commented 1 month ago

@0ba-pia this seems like a duplicate of https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3817

Is either "google drive for desktop " or Windows itself marking the folder as "hidden" on FAT filesystem? If that is indeed the case, then I would argue that the printer behaves correctly.

I don't use Windows myself so I can't recommend any tools for you to check this. Perhaps right-clicking on the directory and selecting properties? Again, I am not a Windows user.

0ba-pia commented 1 month ago

No, the folder isn't marked as "hidden" but it has special properties that are not recognized by the MK4. Please note that the MK3S printers recognize those directories so it is a bug in the way MK4 reads the filesystem.

danopernis commented 1 month ago

Looking at the code, there are two distinct flags in FAT filesystem: "hidden" and "system". If the entry (file or directory, doesn't matter) has any of those attributes set, it is skipped when walking the filesystem. This behavior seems to be quite old, even from MINI times before MK4. I am still not convinced if this is actually a bug, seems like those files are deliberately being ignored.

bkerler commented 2 weeks ago

@0ba-pia Just to understand you right ... you have folders that aren't recognized but if you delete the desktop.ini, then they are recognized ? Could it be that the changes weren't uploaded by google drive / synced before ?