Closed FiveTeethless closed 1 month ago
Nice job, man :) The first two commits look good to me, though I'm not able to evalute the third one - would you be willing to create a separate PR for it that I could delegate to someone else who knows more about the ESP?
I'm currently sick, so it will probably take a bit until I can properly look on the PR. Feel free to remind yourself.
Nice job, man :) The first two commits look good to me, though I'm not able to evalute the third one - would you be willing to create a separate PR for it that I could delegate to someone else who knows more about the ESP?
I'm currently sick, so it will probably take a bit until I can properly look on the PR. Feel free to remind yourself.
Hi, Sorry for the delay. I have taken the other commit out of this pull request.
Thank you, I will try to merge it tomorrow. Feel free to remind me yourself.
Internal ticket: BFW-6223
Hello, sorry, tested your PR it does not seem to work. I will fix it and merge it into our private repository, so it will get out in the next major release, but I cannot merge this PR and I don't have the time budget for doing more rounds with the PR. So closing this one, but it will get fixed and merged.
The problem was that with the cold extrude enabled, the IsTargetTempOk was still not ok, so moving the E was still not possible.
Haha I know, as I tried to explain in my issue, the material temperature prevents this from extruding. I decidded no to change this code as it was your (Prusa Devs) decission to add this user guidance / sanity check to the GUI code. So I think it is your decission to remve it again 😉 I could totally live with the cold-Extrusion-Temp from marlin core. I don't need the guidance from the materials data.
I'm really looking forward to the custom material feature of the 6.2.0, this would actually solve the actual issue I have.
When I load my PVA right now, it almost evaporates when entering the nozzle. 😅
Thanks for taking care of this Danol.
Oh, right, sorry, apparently I haven't read the PR message. Well, anyway, resolved :)
As I found in issue #3674 the screen menu source code has a magic cold extrusion temperature defined as constexpr. The Marlin core actually has a cold ectrusion tempereature and an allowance state, that can be modified with M302.
I modified the marlin_server to give access to this information and modified the GUI code to either ignore the cold extrusion temperature or to check the temperature against the limit of Marlin core.
I have not changed the material's "minimum" temerature check. If this temperature is above marlins cold-extrusion temperature, the material temp will be checked. Just as it was before.
Finally I did a small change in the CMakeLists.txt: As I compile on a Windows machine, I need the Python executable infront of a Python file to run it. I found the variable "${Python3_EXECUTABLE}" somewhere else in the file, so I used it here too.