search

prusa3d / Prusa-Firmware-Buddy

Firmware for the Original Prusa MINI, Original Prusa MK4 and the Original Prusa XL 3D printers by Prusa Research.
Other
1.17k stars 229 forks source link

[BFW-6223] Closes #3870 - improve nozzle diameter footer item #4263

Closed jakubtkadlecek closed 1 month ago

jakubtkadlecek commented 1 month ago

I have found

https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3870

quite distracting during nozzle changes, due to footer item number not corresponding to actual inputted number. Touch version of nozzle diameter input autocorrection feature as well as nozzle diameter warning check in combination with truncated number can in case of mismatch add to confusion.

I have dropped original 'g' formatting in favour of fixed decimal places and manual zero and decimal point removal, since I don't think this is easily achievable otherwise. Appending of dimensions looks a bit iffy, but the use-case seemed like overkill for StringBuilder. Usage of buffer fill could be avoided by testing for 'm' character in the cleaning loop, but results was IMO less understandable.

0.25

nozzle_0_25

0.40

nozzle_0_4

1.00

nozzle_1

1.05

nozzle_1_05

1.10

nozze_1_1
jakubtkadlecek commented 1 month ago

Indeed it does. Thanks for taking the time @CZDanol!

CZDanol commented 1 month ago

Nice, thanks :) I will try to not forget merge it tomorrow. Feel free to remind me.

CZDanol commented 1 month ago

Internal ticket: BFW-6223

jakubtkadlecek commented 1 month ago

Hey @CZDanol! I have addressed nitpicks in the latest commit.

CZDanol commented 1 month ago

Thanks, good job :) I'm waiting for the second approval within the team - then I'll to the merge.