search

prusa3d / Prusa-Firmware-MMU

Other
35 stars 19 forks source link

Defer setting error until ErrDisengagingIdler finishes #189

Closed DRracer closed 2 years ago

DRracer commented 2 years ago

This is an attempt to solving a situation, when the MMU was technically in an error, it was reporting an error and the printer sent a button to resolve it. But because the Idler hasn't disengaged yet, the button was just queued and the next consecutive Q0 query still got a Q0 E<something> response, which really confused the MK3 side.

MMU-170

vintagepc commented 2 years ago

Should we add a test to confirm that an error is indeed emitted after the idler has finished disengaging?

DRracer commented 2 years ago

@vintagepc IMO that's what current tests do (but they do not check if the error gets reported somewhere in the middle of the disengage progress). OK, I'll think about this scenario and add a test case for that