search

prusa3d / Prusa-Firmware-MMU

Other
35 stars 19 forks source link

MMU-206 Check return code from `VerifyEnvironmentState` #249

Closed gudnimg closed 1 year ago

gudnimg commented 1 year ago

A few tests are expected to fail now. I will fix them.

gudnimg commented 1 year ago

1st test run failures summary:

  1. load_filament::failed_load_to_finda_0-4_resolve_manual_no_FINDA
    • Filament load state mismatch. Status is InSelector (2), but AtPulley(1) is expected.
  2. tool_change::test_flickering_FINDA
    • Filament load state mismatch. Status is AtPulley (1) but InSelector (2) is expected.
  3. tool_change::test_flickering_FINDA_keepPressed
    • Filament load state mismatch. Status is AtPulley (1) but InSelector (2) is expected.
  4. tool_change::load_fail_FINDA_resolve_btnM
    • Filament load state mismatch. Status is InSelector (2), but AtPulley(1) is expected.

When FINDA_DIDNT_SWITCH_ON is reported. I would expect the filament status to be AtPulley. We can't really know if the filament is at InSelector.

gudnimg commented 1 year ago

Now tool_change::load_fail_FINDA_resolve_btnM is fixed and all the unit test that broke when I fixed it, are also fixed.

Now just these three left:

gudnimg commented 1 year ago

Taking a break from this for now. I can't quite figure out how to fix the FINDA flickering tests. Those two tests are the only ones left to fix. It looks like VerifyEnvironmentStateis failing due to the selector position is wrong. We expect the position to be wrong, as the FINDA flickers while the selector is moving. But I'm not sure how to fix this in the unit test.