prusa3d / Prusa-Firmware-MMU

Other
32 stars 15 forks source link

logic: eject_filament: reset LED state on OK event #272

Closed gudnimg closed 1 year ago

gudnimg commented 1 year ago

Fix a minor issue where once the FILAMENT_EJECTED error screen is shown on the MK3S+, the LEDs will stay blinking red even after the user has removed the filament and clicked "Done". Note that the issue only appears after having loaded a filament or unloaded it once. Otherwise after boot-up, the LED of the ejected filament is not illuminated since the active slot is never set.

My proposal is to turn the LED off.

Steps to reproduce:

  1. Boot up printer and MMU in a clean state
  2. MK3S+: on the LCD click "Load to Nozzle"
  3. Once the loading is done, click "Unload filament"
  4. Once unloading is done, click "Eject filament"
  5. FILAMENT_EJECTED MMU error screen appears on the printer's UI

IMG_3232

  1. Remove the filament and select "Done".
    • Expected behavior: Blinking red LED turns off (or goes green).
    • Actual behavior: LED continous to blink red with no error screen.

Change in memory: Flash: -48 bytes SRAM: 0 bytes

gudnimg commented 1 year ago

Added another commit which shaves off some memory.