prusa3d / Prusa-Firmware

Firmware for Original Prusa i3 3D printer by PrusaResearch
GNU General Public License v3.0
2.02k stars 1.05k forks source link

[FEATURE REQUEST] Allow cancellation of Live-Z WITHOUT saving adjustment #3352

Closed alexwhittemore closed 12 months ago

alexwhittemore commented 2 years ago

I think this might be a duplicate of https://github.com/prusa3d/Prusa-Firmware/issues/1968, but I honestly can't tell.

If it makes sense, enter what type of printer or upgrade the feature request applies to. Printer type - Mk2.5, but I think all of the Mk<=3 series MMU Upgrade - N/A

I'm a power-user of "press and hold knob to change Z height." I.e. I very regularly finish a print, then press and hold to move the nozzle away. Or more often, cancel a failed print, then press and hold to move the nozzle away.

Helpfully, a few firmware updates ago introduced the ability to press-and-hold the knob to get to the Live Z adjustment while in-print. That's cool, since changing the Z height in a running print makes no sense.

Unhelpfully, the definition of "in a print" is VERY fuzzy, and I literally-every-time I cancel a print try to jog the extruder up, only to accidentally enter the live Z menu and mess it all up.

Since there's no option to cancel a live Z adjustment, my only recourse is to reset the printer at this point.

Describe the solution you'd like In the Adjusting Live Z modal, I'd LOVE a "press and hold to cancel." I.e. tapping the knob commits the new live Z, where long-pressing cancels out without saving the value.

Panayiotis-git commented 2 years ago

The long-press functionality as implemented at the moment is inconsistent. Look at the https://github.com/prusa3d/Prusa-Firmware/pull/3014#issuecomment-776993759 for more details. I believe that this event requires a clear definition, so a user is always sure what to expect from a long-press.

gudnimg commented 2 years ago

Just to highlight the inconsistencies mentioned by @Panayiotis-git below is the menu when the printer is not printing anything. Obviously not all the menus.

Menu Long-Press What does it do?
Status X Open move Z-axis menu
Preheat X Open move Z-axis menu
Print from SD card X Open move Z-axis menu
AutoLoad filament X Exit menu
Unload filament
Settings X Open move Z-axis menu
Calibration X Exit menu
Statistics X Exit menu
Fail stats X Exit menu
Support X Open move Z-axis menu
Settings->Temperature X Open move Z-axis menu
Settings->Move axis X Exit menu
Settings->Crash det. X Exit menu
Settings->HW Setup X Toggle the experimental menu visibility in HW setup
Settings->Mesh Bed Leveling X Exit menu
Settings->Lin. correction X Exit menu
Settings->Live Adjust Z X Open move Z-axis menu
Settings->Select Language X Exit menu
Settings->Brightness X Exit menu
leptun commented 2 years ago

@gudnimg I've updated the HW setup "What it does" column

alexwhittemore commented 2 years ago

TIL that you could move the Z axis while you were already in the middle of live adjust Z. Is that even real?

github-actions[bot] commented 1 year ago

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

github-actions[bot] commented 12 months ago

This issue has been closed due to lack of recent activity.