search

prusa3d / Prusa-Firmware

Firmware for Original Prusa i3 3D printer by PrusaResearch
GNU General Public License v3.0
2.02k stars 1.05k forks source link

Add support for MK3S Revo HT 40W hot end #4487

Closed b closed 7 months ago

b commented 12 months ago

This code adds support to the MK3S for the e3d Revo high temperature hot end with the 40W precision heater and PT1000 thermistor. Works on my machine.

github-actions[bot] commented 12 months ago

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG -1132 -18 246032 5638 7920 2554
MK3_MULTILANG -1128 -16 245318 5647 8634 2545
3d-gussner commented 11 months ago

@b Thanks for the PR I forwarded this to E3D as your PR ONLY contains ONE set of data points.

b commented 10 months ago

Is there anything else I need to do to make this PR acceptable for merging?

3d-gussner commented 10 months ago

@b I have been in contact with E3D about this PR and there are few reasons we didn't approved this PR

  1. The max high temperature of 405°C may soften the plastic parts which are made in PETG (ASA/ABS fan-duct). The extruder would need to be printed in a different material that can withstand the heat radiation.
  2. The TM values base only on YOUR printer and will not represent the wider possible range. a. For the E3DRevo TM values we collected multiple test results from the community and E3D also provided more data to get "good" average TM values for these. b. So you may need to ask other community members to test and update then the TM values
  3. Each variant must have it's own variant and TM file. Please don't use this and this anymore a. I know there is the existing #elif defined but this is an very old community merge and we won't change it

Hope that you get some help from the community so we can consider to review this PR again. The provided the E3D REVO hex files in the official release builds are an exception as E3D approved these. But please understand that we will not build and provide the hex files for each 3rd party variant there may come in the official releases. Meaning the community will have to compile the firmware themself.

3d-gussner commented 7 months ago

Closing as no interaction or update