search

prusa3d / Prusa-Firmware

Firmware for Original Prusa i3 3D printer by PrusaResearch
GNU General Public License v3.0
2k stars 1.05k forks source link

Change Reprint action message to comply with OctoPrint actions #4520

Closed 3d-gussner closed 8 months ago

3d-gussner commented 8 months ago

Changing the Reprint action message to // action:start complies with the OctoPrint action to restart (Reprint) a selected file.

The Reprint menu is now only shown when the host "pingsthe printer usingM79` to ensure a host is listening to the serial output.

So to enable Reprint for a OctoPrint print it has to send M79 within 30 seconds between two to keep the host-is-alive-timer going.

Adding M79 S"OP" to OctoPrint --> Settings --> GCODE scripts -> After serial connection to printer is established starts the timer and sets the short name of the host OctoPrint

An OctoPrint plugin would be necessary to "ping" the MK3S printers every few seconds. Alternative to active the Reprint LCD menu would be to send M79 from OctoPrint but at the same time it doesn't makes sense as the user easily can press the Start button

@jfestrada Please also review this PR

github-actions[bot] commented 8 months ago

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 6 0 247110 5656 6842 2536
MK3_MULTILANG 6 0 246392 5663 7560 2529
3d-gussner commented 8 months ago

@TojikCZ Please review and update PrusaLink for MK3S

jfestrada commented 8 months ago

It seems to be OK

3d-gussner commented 8 months ago

@DRracer @wavexx @gudnimg @leptun can someone please approve this PR @jfestrada and @TojikCZ approved it in the comment above but I need an official approve (and I don't want to approve my own PR) to merge it.

sarusani commented 8 months ago

@3d-gussner I created a simple octoprint plugin that sends 'M79 S"OP"' every 10 seconds. Feel free to use it to test the host features. https://github.com/sarusani/OctoPrint-ActivatePrusaHostTimer/archive/master.zip

3d-gussner commented 8 months ago

@sarusani Awesome, thanks. It works, would be nice to be able to enable/disable it

sarusani commented 8 months ago

@3d-gussner Just pushed a new version. You can now configure the interval on the settings page and pause the ping.

It's available through the plugin manager, look for "Activate Prusa HostTimer". (https://plugins.octoprint.org/plugins/ActivatePrusaHostTimer/)